Skip to content

2D & 3D Heatmaps #5130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 4, 2025
Merged

2D & 3D Heatmaps #5130

merged 24 commits into from
Aug 4, 2025

Conversation

Rishab87
Copy link
Contributor

Description

Added plot_3d_cross_section & plot_3d_heatmap functions to support plotting for 3D thermal simulations.

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Rishab87 Rishab87 requested a review from a team as a code owner July 22, 2025 13:50
@Rishab87
Copy link
Contributor Author

@rtimms can you please review it?

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.09%. Comparing base (d421e3a) to head (5b84828).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #5130    +/-   ##
=========================================
  Coverage    99.08%   99.09%            
=========================================
  Files          310      312     +2     
  Lines        24459    24660   +201     
=========================================
+ Hits         24236    24437   +201     
  Misses         223      223            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@agriyakhetarpal agriyakhetarpal added the GSoC 2025 Items being done as part of GSoC 2025 label Jul 27, 2025
@Rishab87
Copy link
Contributor Author

@rtimms I've changed the file name. Can you please re-review?

@rtimms rtimms enabled auto-merge (squash) August 4, 2025 13:06
@rtimms rtimms merged commit a75962c into pybamm-team:develop Aug 4, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSoC 2025 Items being done as part of GSoC 2025
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants