3D Thermal Model #5112
Merged
3D Thermal Model #5112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtimms can you review this? (also run the CI wanted to see coverage) |
…into gsoc-3d-thermal
rtimms
requested changes
Jul 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5112 +/- ##
=========================================
Coverage 99.12% 99.12%
=========================================
Files 309 310 +1
Lines 24136 24313 +177
=========================================
+ Hits 23924 24101 +177
Misses 212 212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@rtimms , I've addressed the reviews and coverage in unit tests. Can you please re-review it? |
rtimms
requested changes
Jul 21, 2025
| @@ -30,6 +30,8 @@ def battery_geometry( | |||
| """ | |||
| if options is None or type(options) == dict: # noqa: E721 | |||
| options = pybamm.BatteryModelOptions(options) | |||
| if options["cell geometry"] == "cylindrical": | |||
There was a problem hiding this comment.
Since form_factor is a kwarg of this method, I don't think we should update it in this way. Instead, we should catch it earlier and explicitly pass form_factor to battery_geometry
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
…into gsoc-3d-thermal
|
@rtimms I've addressed all reviews, can you please re-review it? |
rtimms
previously approved these changes
Jul 21, 2025
rtimms
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a
Basic3DThermalSPMmodel with two way coupling.Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests