bug: enforce sensitivity shape consistency #5098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5098 +/- ##
===========================================
- Coverage 99.10% 99.09% -0.01%
===========================================
Files 307 307
Lines 23686 23691 +5
===========================================
+ Hits 23473 23477 +4
- Misses 213 214 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcBerliner
requested changes
Jul 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an inconsistency in the shape of the value and sensitivities of a discrete time sum or explicit time integral depending on if output_variables was set or not
Ran into a bug in the sensitivity calculation if the variable was sparse, this might be related to #5058. I've added an explicit check to see if the variable is sparse, and the solver will raise an error if you try to calculate sensitivities of the sparse variable.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests