Skip to content

Drive cycle: infer duration from data by default + fix period argument #5090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 1, 2025
Merged

Drive cycle: infer duration from data by default + fix period argument #5090

merged 9 commits into from
Jul 1, 2025

Conversation

MarcBerliner
Copy link
Member

@MarcBerliner MarcBerliner commented Jul 1, 2025 •
edited
Loading

Description

Fixes a bug that ignored the default duration of drive cycles for CRate steps and a bug that overwrote custom period arguments for drive cycles.

Fixes #5086 and #5087

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@MarcBerliner MarcBerliner marked this pull request as ready for review July 1, 2025 13:44
@MarcBerliner MarcBerliner requested a review from a team as a code owner July 1, 2025 13:44
@MarcBerliner MarcBerliner linked an issue Jul 1, 2025 that may be closed by this pull request
[Bug]: Period for drive cycle experiment step gets overwritten by data #5087
Closed
@MarcBerliner MarcBerliner enabled auto-merge (squash) July 1, 2025 13:49
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (09c6cc0) to head (a0dd86c).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #5090   +/-   ##
========================================
  Coverage    99.12%   99.12%           
========================================
  Files          304      304           
  Lines        23540    23544    +4     
========================================
+ Hits         23334    23338    +4     
  Misses         206      206

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner merged commit 9662460 into develop Jul 1, 2025
22 checks passed
@MarcBerliner MarcBerliner deleted the fix-drive-cycle-duration-period branch July 1, 2025 14:36
@Daniel-Nicolae23
Copy link

Thanks for the promptness Marc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtimms rtimms rtimms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Period for drive cycle experiment step gets overwritten by data [Bug]: C-rate drive cycle calls wrong default duration
4 participants
@MarcBerliner @Daniel-Nicolae23 @rtimms @kratman