Skip to content

Remove IREE helper functions #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 26, 2025
Merged

Remove IREE helper functions #5082

merged 7 commits into from
Jun 26, 2025

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jun 25, 2025 •
edited
Loading

Description

This should be the last of the IREE removal changes

Fixes #5077

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Jun 25, 2025
@kratman
Copy link
Contributor Author

kratman commented Jun 25, 2025

This is waiting on #5080

@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (12432a8) to head (e38355e).
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5082      +/-   ##
===========================================
+ Coverage    98.57%   99.12%   +0.54%     
===========================================
  Files          304      304              
  Lines        23740    23540     -200     
===========================================
- Hits         23402    23334      -68     
+ Misses         338      206     -132

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kratman kratman marked this pull request as ready for review June 26, 2025 10:44
@kratman kratman requested a review from a team as a code owner June 26, 2025 10:44
@kratman kratman merged commit 09c6cc0 into pybamm-team:develop Jun 26, 2025
22 checks passed
@kratman kratman deleted the chore/removeHelpers branch June 26, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcBerliner MarcBerliner MarcBerliner approved these changes

Assignees

@kratman kratman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tracking issue: IREE removal
2 participants
@kratman @MarcBerliner