Skip to content

Remove most of IREE from the solvers #5080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 26, 2025
Merged

Remove most of IREE from the solvers #5080

merged 6 commits into from
Jun 26, 2025

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jun 25, 2025 •
edited
Loading

Description

Removing most of the IREE solver and Jax code inside pybammsolvers.

Related #5077

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Jun 25, 2025
@kratman kratman requested a review from a team as a code owner June 25, 2025 20:14
@kratman kratman marked this pull request as draft June 25, 2025 20:15
@kratman kratman marked this pull request as ready for review June 25, 2025 20:26
@codecov Codecov
Copy link

codecov bot commented Jun 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.09%. Comparing base (12432a8) to head (ed73019).
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5080      +/-   ##
===========================================
+ Coverage    98.57%   99.09%   +0.51%     
===========================================
  Files          304      304              
  Lines        23740    23586     -154     
===========================================
- Hits         23402    23372      -30     
+ Misses         338      214     -124

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

kratman
kratman commented Jun 25, 2025
View reviewed changes
Copy link
Contributor Author

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo

@kratman kratman mentioned this pull request Jun 25, 2025
Merged
martinjrobins
martinjrobins approved these changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @kratman

@kratman kratman merged commit 7155b62 into pybamm-team:develop Jun 26, 2025
22 checks passed
@kratman kratman deleted the chore/removeIREESolver branch June 26, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjrobins martinjrobins martinjrobins approved these changes

Assignees

@kratman kratman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kratman @martinjrobins