Skip to content

feat: Discrete Time Sum and Explicit Time Integral support for output variables #5071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 1, 2025
Merged

feat: Discrete Time Sum and Explicit Time Integral support for output variables #5071

merged 5 commits into from
Jul 1, 2025

Conversation

martinjrobins
Copy link
Contributor

@martinjrobins martinjrobins commented Jun 23, 2025 •
edited
Loading

Description

Allows pybamm.DiscreteTimeSum and pybamm.ExplicitTimeIntegral variables to work with the output_varables solver option

Fixes #5063

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@martinjrobins martinjrobins changed the title start on supporting dts and explicit time integal for ouput vars feat: Discrete Time Sum and Explicit Time Integral support for output variables Jun 30, 2025
@martinjrobins martinjrobins marked this pull request as ready for review June 30, 2025 13:48
@martinjrobins martinjrobins requested a review from a team as a code owner June 30, 2025 13:48
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (09c6cc0) to head (aa7288c).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5071      +/-   ##
===========================================
- Coverage    99.12%   99.12%   -0.01%     
===========================================
  Files          304      304              
  Lines        23540    23573      +33     
===========================================
+ Hits         23334    23366      +32     
- Misses         206      207       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

BradyPlanden
BradyPlanden approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@BradyPlanden BradyPlanden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @martinjrobins. I can also confirm this works as expected on the PyBOP side.

@kratman kratman enabled auto-merge (squash) July 1, 2025 16:51
@kratman kratman merged commit eac0b55 into develop Jul 1, 2025
22 checks passed
@kratman kratman deleted the i5063-dts-output-var branch July 1, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kratman kratman kratman approved these changes

+1 more reviewer

@BradyPlanden BradyPlanden BradyPlanden approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Discrete Time Sum and Explicit Time Integral support for output variables
3 participants
@martinjrobins @kratman @BradyPlanden