Skip to content

Deprecate python 3.9 support #5052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 16, 2025
Merged

Deprecate python 3.9 support #5052

merged 10 commits into from
Jun 16, 2025

Conversation

kratman
Copy link
Contributor

@kratman kratman commented Jun 9, 2025

Description

This is earlier than necessary (~October), but it makes the switch to numpy 2.0 easier.

Related: #4183

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@kratman kratman self-assigned this Jun 9, 2025
@kratman kratman requested a review from a team as a code owner June 9, 2025 16:29
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@codecov Codecov
Copy link

codecov bot commented Jun 9, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.52941% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.58%. Comparing base (563c100) to head (44ba595).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/pybamm/solvers/idaklu_solver.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #5052      +/-   ##
===========================================
- Coverage    98.58%   98.58%   -0.01%     
===========================================
  Files          304      304              
  Lines        23725    23723       -2     
===========================================
- Hits         23389    23387       -2     
  Misses         336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Saransh-cpp
Saransh-cpp requested changes Jun 15, 2025
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kratman! This looks good.

A few 3.9 occurrence that you missed -

PyBaMM/pyproject.toml

Line 25 in 563c100

"Programming Language :: Python :: 3.9",

(these are a bit annoying) -

https://github.com/pybamm-team/PyBaMM/blob/develop/docs/source/user_guide/installation/gnu-linux-mac.rst#prerequisites

https://github.com/pybamm-team/PyBaMM/blob/develop/docs/source/user_guide/installation/windows.rst#prerequisites

https://github.com/pybamm-team/PyBaMM/blob/develop/docs/source/user_guide/installation/install-from-source.rst#prerequisites

@Saransh-cpp Saransh-cpp mentioned this pull request Jun 15, 2025
Merged
8 tasks
@kratman kratman requested a review from Saransh-cpp June 16, 2025 00:06
@kratman
Copy link
Contributor Author

kratman commented Jun 16, 2025

Thanks @Saransh-cpp, I fixed the ones you pointed out and found a couple others

kratman
kratman commented Jun 16, 2025
View reviewed changes
Copy link
Contributor Author

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing a mistake from the pre-commit changes that was not caught by tests

Saransh-cpp
Saransh-cpp approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @kratman!

It would be nice to set strict=True in all zips (in another PR by someone else) to avoid silent bugs.

@Saransh-cpp Saransh-cpp mentioned this pull request Jun 16, 2025
Open
agriyakhetarpal
agriyakhetarpal approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'm okay with dropping support for Python 3.9 (I'm coming from @Saransh-cpp's comment at #4490), but I would delegate the decision to others.

@kratman
Copy link
Contributor Author

kratman commented Jun 16, 2025 •
edited
Loading

Nice, thanks @kratman!

It would be nice to set strict=True in all zips (in another PR by someone else) to avoid silent bugs.

Yeah I agree. I did not want to do both in this single PR. It also bothers me that the tests did not catch the error from the itertools.pairwise() change. It is possible that we have other silent issues. I will make a ticket for the strict part.

edit: I see there is already a ticket for it. I will just add more context

brosaplanella
brosaplanella approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@kratman kratman merged commit 3144907 into pybamm-team:develop Jun 16, 2025
21 of 22 checks passed
@kratman kratman deleted the chore/deprecate39 branch June 16, 2025 16:09
@agriyakhetarpal agriyakhetarpal mentioned this pull request Jun 16, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brosaplanella brosaplanella brosaplanella approved these changes

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

Assignees

@kratman kratman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kratman @brosaplanella @Saransh-cpp @agriyakhetarpal