Skip to content

fix: DiscreteTimeSum sensitivity calculation dimensions #5037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2025
Merged

fix: DiscreteTimeSum sensitivity calculation dimensions #5037

merged 3 commits into from
Jun 2, 2025

Conversation

BradyPlanden
Copy link
Member

Description

Fixes #5036

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@BradyPlanden BradyPlanden requested a review from a team as a code owner May 30, 2025 09:40
@codecov Codecov
Copy link

codecov bot commented May 30, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.58%. Comparing base (e1c0c87) to head (946df01).
⚠️ Report is 195 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #5037   +/-   ##
========================================
  Coverage    98.58%   98.58%           
========================================
  Files          304      304           
  Lines        23689    23691    +2     
========================================
+ Hits         23353    23355    +2     
  Misses         336      336

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

martinjrobins
martinjrobins requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BradyPlanden. Would you mind also adding some comments here on the dimensions of the sensitivity variables and why the transpose is needed?

martinjrobins
martinjrobins requested changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, as discussed we are currently doing DM -> numpy -> DM, can we change the vertcat to numpy so its just DM->numpy

martinjrobins
martinjrobins previously approved these changes Jun 2, 2025
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay, don't have to stick full() everywhere in the tests :)

@martinjrobins martinjrobins merged commit 62530b6 into pybamm-team:develop Jun 2, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinjrobins martinjrobins martinjrobins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: DiscreteTimeSum sensitivities error for input dimensions > 1
2 participants
@BradyPlanden @martinjrobins