I4545-remove-explicit-sens #4975
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4975 +/- ##
===========================================
- Coverage 98.60% 98.57% -0.04%
===========================================
Files 304 304
Lines 23809 23641 -168
===========================================
- Hits 23478 23305 -173
- Misses 331 336 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcBerliner
requested changes
Apr 16, 2025
There was a problem hiding this comment.
Thanks for working on this @martinjrobins! It makes the code so much cleaner :)
Just a few minor comments
Comment on lines
328
to
335
| sens_idaklu = np.interp( | ||
| solutions[1].t[:-2], | ||
| solutions[3].t, | ||
| solutions[3]["Voltage [V]"] | ||
| t, | ||
| solutions[1].t, | ||
| solutions[1]["Voltage [V]"] | ||
| .sensitivities[input_param_name] | ||
| .full() | ||
| .flatten(), | ||
| ) |
There was a problem hiding this comment.
Can we change this to a higher order interpolator
There was a problem hiding this comment.
I tried this but it doesn't work very well due to the discontinuities in the experiment, linear interp behaves better
MarcBerliner
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4545
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)
Important checks:
Please confirm the following before marking the PR as ready for review:
nox -s pre-commitnox -s testsnox -s doctests