Skip to content

Fix IDAKLU bug with non-identity inverse mass matrices #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 28, 2025
Merged

Fix IDAKLU bug with non-identity inverse mass matrices #4879

merged 3 commits into from
Feb 28, 2025

Conversation

MarcBerliner
Copy link
Member

Description

For more info, see: #4878 (comment)

This is a minor bug that practically only affects FEM simulations using the IDAKLUSolver

I will make a followup PR in pybammsolvers to address a related issue there: pybamm-team/pybammsolvers#31

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov Codecov
Copy link

codecov bot commented Feb 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (f171572) to head (6951398).
Report is 78 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #4879   +/-   ##
========================================
  Coverage    98.70%   98.71%           
========================================
  Files          304      304           
  Lines        23482    23495   +13     
========================================
+ Hits         23179    23192   +13     
  Misses         303      303

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarcBerliner MarcBerliner marked this pull request as ready for review February 26, 2025 21:14
@MarcBerliner MarcBerliner requested a review from a team as a code owner February 26, 2025 21:14
@rtimms rtimms merged commit 174c1c8 into develop Feb 28, 2025
26 checks passed
@rtimms rtimms deleted the mdb/standard-form-dae branch February 28, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtimms rtimms rtimms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcBerliner @rtimms