Sei composite multiparticle #4693
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4693 +/- ##
===========================================
+ Coverage 99.22% 99.25% +0.02%
===========================================
Files 303 303
Lines 23070 23232 +162
===========================================
+ Hits 22891 23058 +167
+ Misses 179 174 -5 ☔ View full report in Codecov by Sentry. |
|
Should we revert? Looking at it I don't think it will be this but I think we need to be careful with PR's that mess with submodels, they're just so darn finicky. |
|
How did it get merged? I had it on auto-merge which should wait until checks pass right?? |
|
Yeah it is just an issue with auto-merge and our CI. Tests are not required yet The test failures are string precision, so I am fixing them now. I don't see any failures from your changes, I double checked locally |
|
If auto merge doesn't wait for tests I think we should not let people use it if that's possible |
A lot of tests were not required on PyBaMM because it blocked bot created PRs from merging. I am starting to enforce these things |
Description
make sei work with particle size distributions
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python -m pytest(or$ nox -s tests)$ python -m pytest --doctest-plus src(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ nox -s quick.Further checks: