Skip to content

Conversation

jmakov
Copy link
Contributor

@jmakov jmakov commented Apr 24, 2024

Related Issue or bug

pyyaml version fix prevents pycaret[full] to be installed. Would be great if somebody could add an install test for CI/CD or to just run pip install -e .[full] and check the output.

Closes #3970

Describe the changes you've made

Removed pyyaml version fixation in requirements-optional.txt

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Local install for python 3.10, 3.11, doesn't work for 3.12.

git clone git@github.com:pycaret/pycaret.git
cd pycaret
# in `requirements-optional.txt` change `pyyaml == 5.4.1` to `pyyaml`
mamba create -n test python=3.10 # works also for 3.11, doesn't work for 3.12
mamba activate test
pip install .[full]

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA
A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@jmakov jmakov force-pushed the bugfix/fix_pyyaml_breaking_install branch from cd36fb5 to 6f4c297 Compare April 24, 2024 13:07
@jmakov jmakov changed the title Remove pyyaml version fix Fix pycaret[full] cannot be installed Apr 24, 2024
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Yard1 Yard1 merged commit c62c7d6 into pycaret:master Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[INSTALL]: cannot install pycaret[full]
2 participants