-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Support Scikit-learn 1.4 #3857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Scikit-learn 1.4 #3857
Conversation
…noxp/pycaret into support-scikit-learn-1.4
base_estimator - This parameter is deprecated. Use estimator instead. Deprecated since version 1.2: The parameter base_estimator is deprecated in 1.2 and will be removed in 1.4. Use estimator instead.
Fix warning: SAMME.R is deprecated and will be removed in scikit-learn 1.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really a complete review, just two things I noticed.
Happy to review, but I think you should first figure out dependency issues 😉
Once the CI runs, happy to be pinged for a review. Or if you have any particular questions, also happy to jump in. |
@adrinjalali i think problem is pyod is a depencencie of pycaret and not support scikit-learn 1.4. |
In the latest release, you get warnings when |
pyod is blockig github tests, so it is deactivated unti support scikit-learn 1.4
I thought that the use_line_collection error was from the shap package, but after all it is reproduced by matplotlib and the cause is in the yellowbrics package, that is, yellowbrics should remove use_line_collection. I opened an issue: DistrictDataLabs/yellowbrick#1312 and as soon as it is resolved, we should update the yellowbrics version
when removed SAMME.R i removed the type, i removed [ ]. It still be a list
@Yard1 @adrinjalali @glemaitre I'm testing on my laptop because scikit-learn 1.4 has a bug that has already been fixed, but we can only use 1.4.1, so I'm using the nightly version. It's embarrassing that this PR is stuck while scikit-learn 1.4.1 is not released, even worse is that I don't know how to solve it!!! So I ask for your help to solve this problem (if you can analyze the code on your machines): |
That doesn't look like a bug to me at all. It seems it's because you are trying to get |
time-series failling! can you help to fix this pr? @ngupta23 @fkiraly @yarnabrina |
Hi @celestinoxp, it seems that there is just one failure.
(Ref. https://github.com/pycaret/pycaret/actions/runs/7958439755/job/21723320810?pr=3857#step:6:3841) And the logs suggest it's from classification.
(Ref. https://github.com/pycaret/pycaret/actions/runs/7958439755/job/21723320810?pr=3857#step:6:95) It does not look like |
Hi @yarnabrina At the time I asked for help I was having a timeseries error, but I think I've already solved it... however now this error has appeared... ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all(). I still haven't found where the problem comes from... It's a shame that so far no one has collaborated to resolve this PR... the funny thing is that I'm just a self-taught person without enough knowledge for a PR of this magnitude... |
how to fix this? FAILED tests/test_optimize_threshold.py::test_optimize_threshold - ValueError: The truth value of a Series is ambiguous. Use a.empty, a.bool(), a.item(), a.any() or a.all(). |
Signed-off-by: Antoni Baum <antoni.baum@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your hard work! If tests pass I'll merge and release.
This PR serves some simple and superficial modifications to pycaret so that it supports scikit-learn 1.4.
Closes #3795