Skip to content

Conversation

pascal456
Copy link
Contributor

Related Issue or bug

tracked in #3841

Closes #3841

Describe the changes you've made

I have checked what features / APIs derive from the current supported version. Raised the version in requirements.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I have run all relevant tests (as far as I could find out) against the following mlflow client versions:

  • 2.0.0 (yanked version; oldest compatible)
  • 2.9.0 (latest at time writing this)

I have run all the tests; passing locally. Tests of special interest are:

def test_anomaly(data):

def test_classification_models_with_experiment_custom_tags(self, juice_dataframe):

def test_clustering(data):

def test_regression_models_with_experiment_custom_tags(self, boston_dataframe):

def test_mlflow_logging(load_pos_and_neg_data):

def test_mlflow_log_setup(load_pos_and_neg_data):

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@pascal456 pascal456 force-pushed the 3841-ENH-raise-supported-MLflow-version-pascal456 branch from 94fb279 to b27813d Compare December 6, 2023 19:41
@pascal456 pascal456 force-pushed the 3841-ENH-raise-supported-MLflow-version-pascal456 branch from b27813d to f8f96e6 Compare December 6, 2023 19:55
@tvdboom tvdboom self-requested a review December 14, 2023 21:00
@tvdboom
Copy link
Collaborator

tvdboom commented Dec 14, 2023

Thanks for the contribution!

@tvdboom tvdboom merged commit 7943536 into pycaret:master Dec 14, 2023
@pascal456 pascal456 deleted the 3841-ENH-raise-supported-MLflow-version-pascal456 branch December 15, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: raise supported MLflow version
2 participants