Skip to content

Conversation

amotl
Copy link
Contributor

@amotl amotl commented Nov 6, 2023

Hi Antoni,

while working on GH-3814, we discovered the style of running specific groups of test cases by removing files from the tests/ folder. This patch steers that detail into a different direction, by using pytest markers and pytest.skip() annotations instead. We hope you like that approach.

In this spirit, by using this style of discriminating the test cases within the CI/GHA workflow definition file, it becomes much easier to maintain.

With kind regards,
Andreas.

References

@amotl
Copy link
Contributor Author

amotl commented Nov 6, 2023

Outcome

image
-- https://github.com/crate-workbench/pycaret/actions/runs/6763741630

Python 3.11 / Windows

Tests also fail here, but already at dependency installation time, so completely different than GH-3814. I am currently trying to get a Windows environment up and running, in order to investigate why it pulls numpy==1.21.3 there.

Collecting tensorboardX>=1.9 (from ray[tune]>=1.0.0; extra == "full")
  Downloading tensorboardX-2.6.2.2-py2.py3-none-any.whl.metadata (5.8 kB)
Collecting pyarrow>=0.15.1 (from fugue>=0.8.0)
  Downloading pyarrow-6.0.1.tar.gz (770 kB)
     ------------------------------------- 770.7/770.7 kB 24.5 MB/s eta 0:00:00
  Installing build dependencies: started
  Installing build dependencies: finished with status 'error'
  error: subprocess-exited-with-error
  
  pip subprocess to install build dependencies did not run successfully.
  exit code: 1
  
  [8 lines of output]
  Ignoring numpy: markers 'python_version < "3.8"' don't match your environment
  Ignoring numpy: markers 'python_version == "3.8"' don't match your environment
  Ignoring numpy: markers 'python_version == "3.9"' don't match your environment
  Collecting cython>=0.29
    Using cached Cython-3.0.5-cp311-cp311-win_amd64.whl.metadata (3.2 kB)
  ERROR: Ignored the following versions that require a different python version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11
  ERROR: Could not find a version that satisfies the requirement numpy==1.21.3 (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.4, 1.11.0, 1.11.1, 1.11.2, 1.11.3, 1.12.0, 1.12.1, 1.13.0, 1.13.1, 1.13.3, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0, 1.19.1, 1.19.2, 1.19.3, 1.19.4, 1.19.5, 1.20.0, 1.20.1, 1.20.2, 1.20.3, 1.21.0, 1.21.1, 1.22.0, 1.22.1, 1.22.2, 1.22.3, 1.22.4, 1.23.0rc1, 1.23.0rc2, 1.23.0rc3, 1.23.0, 1.23.1, 1.23.2, 1.23.3, 1.23.4, 1.23.5, 1.24.0rc1, 1.24.0rc2, 1.24.0, 1.24.1, 1.24.2, 1.24.3, 1.24.4, 1.25.0rc1, 1.25.0, 1.25.1, 1.25.2, 1.26.0b1, 1.26.0rc1, 1.26.0, 1.26.1)
  ERROR: No matching distribution found for numpy==1.21.3

References

@Yard1 Yard1 self-requested a review November 6, 2023 01:53
@Yard1
Copy link
Member

Yard1 commented Nov 6, 2023

This is quite interesting, please mark it as ready for review when you are done!

amotl added 5 commits November 6, 2023 14:54
It wants to install `numpy==1.21.3`, for whatever reason, but that
version does not exist.

  ERROR: Ignored the following versions that require a different python version: 1.21.2 Requires-Python >=3.7,<3.11; 1.21.3 Requires-Python >=3.7,<3.11; 1.21.4 Requires-Python >=3.7,<3.11; 1.21.5 Requires-Python >=3.7,<3.11; 1.21.6 Requires-Python >=3.7,<3.11
  ERROR: Could not find a version that satisfies the requirement numpy==1.21.3
Fuse GHA/pytest configurations into single workflow recipe.
@amotl
Copy link
Contributor Author

amotl commented Nov 6, 2023

As demonstrated at 1, this patch now also succeeds on all test matrix slots. Therefore, I am flagging it as ready for review, but GH-3814 should go in first.

image

Footnotes

  1. https://github.com/crate-workbench/pycaret/actions/runs/6771777134

@amotl amotl marked this pull request as ready for review November 6, 2023 20:27
@amotl amotl mentioned this pull request Nov 8, 2023
5 tasks
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great!

@Yard1 Yard1 merged commit f4e3d9a into pycaret:support-311 Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants