Skip to content

fix error raise in compare_models #3773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix error raise in compare_models #3773

merged 1 commit into from
Oct 9, 2023

Conversation

tvdboom
Copy link
Collaborator

@tvdboom tvdboom commented Oct 8, 2023 •
edited
Loading

Closes #3738

Describe the changes you've made

Errors in compare_models are now properly raised when errors=True.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tvdboom tvdboom requested a review from Yard1 October 8, 2023 19:22
Yard1
Yard1 approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tvdboom tvdboom merged commit 845642a into master Oct 9, 2023
@tvdboom tvdboom deleted the raise_error_fail_predict branch October 9, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] compare_models doesn't raise an error when errors='raise' and model fails
2 participants
@tvdboom @Yard1