Skip to content

Scikit-learn 1.3.x support #3750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Scikit-learn 1.3.x support #3750

wants to merge 11 commits into from

Conversation

celestinoxp
Copy link
Contributor

Related Issue or bug

Scikit-learn 1.3.x support
Note: Latest scikit-learn is 1.3.1, but 1.3.0 not supported because c_contiguous bug.

@celestinoxp
Fix python support
3dfe919 
This change is to avoid problems with versions of Python that are no longer supported such as Python 3.7
@celestinoxp
fix bug
844124f 
fix bug, now accept python 3.10.x
@celestinoxp
Update __init__.py
8f9351a
@celestinoxp
Fix python support
10deb6e 
This change is to avoid problems with versions of Python that are no longer supported such as Python 3.7
@celestinoxp
fix bug
1c31c9e 
fix bug, now accept python 3.10.x
@celestinoxp
Update __init__.py
9347ba0
@celestinoxp
Merge branch 'fix-python-version-38-310' of https://github.com/celest…
50df29b 
…inoxp/pycaret into fix-python-version-38-310
@celestinoxp
simplify version checks
b3bcccb 
simplify version checks
@celestinoxp
try resolve flake8 problems #part1
2632b3c 
i installed flake8 in vscode
@celestinoxp
Support XGBoost 2
1733380 
some changes to support xgboost 2.0 and higher
@celestinoxp
support scikit-learn 1.3.x
3ef6939 
Support scikit-learn 1.3.x
 - version 1.3.0 not supported because c_contiguous bug
- latest version is 1.3.1 should work (resolve if exist any future problems)
@celestinoxp
Copy link
Contributor Author

@tvdboom can you help with support for scikit-learn 1.3.1?
Problem in tests, custom_metric gives zero...
FAILED tests/test_classification.py::test_classification_custom_metric

I enabled Allow edits by maintainers, so you can change my pr freely :) Thanks

@celestinoxp
Copy link
Contributor Author

test_failed classification scores maybe need changes related to https://github.com/scikit-learn/scikit-learn/pull/27002/files ?

@tvdboom
Copy link
Collaborator

tvdboom commented Sep 28, 2023

@celestinoxp you are making changes related to multiple prs here. You need to make a new branch from master every time you change code for a new pr. I'm gonna close this PR since the changes here are discussed in #3749. If you want to bump the sklearn version, you can do it in that PR as well. Also if you do so, write in a comment next to the requirements file why 1.3.0 is not supported, with a link to the issue in sklearn's github. Thanks

@tvdboom tvdboom closed this Sep 28, 2023
@tvdboom tvdboom mentioned this pull request Sep 28, 2023
Merged
13 tasks
@celestinoxp celestinoxp deleted the scikit_learn_1_3_support branch February 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@celestinoxp @tvdboom