Skip to content

Fix for sktime changes in recent versions #3652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 24, 2023
Merged

Fix for sktime changes in recent versions #3652

merged 5 commits into from
Jul 24, 2023

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Jul 22, 2023 •
edited
Loading

Related Issue or bug

Tests were failing on CI for time series and other modules. This PR is to fix the time series tests.

Describe the changes you've made

  • sktime BoxCoxTrandformer supports negative values in recent versions. Hence, tests have been updated appropriately
  • Recent versions of sktime introduced a legacy interface argument. This needs to be incorporated in Prophet Patched class in pycaret.
  • Pinned sktime upper limit for now. Once the new interface is supported (along with older interface - depending on sktime version), we can remove the limit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Failing time series unit tests have been checked locally for sktime vesions 0.19.1 and 0.21.0.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 requested review from tvdboom and Yard1 July 22, 2023 15:11
@ngupta23 ngupta23 added this to the 3.0.5 milestone Jul 22, 2023
@ngupta23 ngupta23 added the time_series Topics related to the time series label Jul 22, 2023
@tvdboom
Copy link
Collaborator

tvdboom commented Jul 22, 2023

lgtm, given that the tests pass

@ngupta23
Copy link
Collaborator Author

lgtm, given that the tests pass

Thanks for the review. This will only clear the time series failures. :)
Other modules will have to be fixed in a separate PR.

Yard1
Yard1 approved these changes Jul 22, 2023
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ngupta23
Copy link
Collaborator Author

ngupta23 commented Jul 23, 2023 •
edited
Loading

@tvdboom @Yard1

It looks like tests are failing for both time series and non time series modules in python 3.7 but passing in 3.8, 3.9 and 3.10. We need to look deeper into it and decide if we need to fix python 3.7 or drop support for it.

image

@Yard1
Copy link
Member

Yard1 commented Jul 23, 2023

I think we should drop it.

@ngupta23 ngupta23 merged commit 6662100 into master Jul 24, 2023
@ngupta23 ngupta23 deleted the fix_ts_deprecations branch July 24, 2023 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@tvdboom tvdboom tvdboom approved these changes

Assignees
No one assigned
Labels
time_series Topics related to the time series
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ngupta23 @tvdboom @Yard1