Skip to content

Conversation

beingmechon
Copy link
Contributor

@beingmechon beingmechon commented Jul 19, 2023

Related Issue or bug

Info about Issue or bug

Closes #3645

Describe the changes you've made

Updated the old deprecated libraries to newly updated libraries in the source code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested the package on my forked repo.
Test can be produced using the following set of code

!pip install git+https://github.com/beingmechon/pycaret.git
!pip install ydata-profiling

from pycaret.datasets import get_data
from pycaret.regression import setup
dataset1 = get_data("diamond", profile=True)

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@ngupta23
Copy link
Collaborator

Hi @beingmechon - Could you fix the code quality issues, please? Thanks!

ngupta23 and others added 3 commits July 23, 2023 22:05
@beingmechon
Copy link
Contributor Author

Hi @beingmechon - Could you fix the code quality issues, please? Thanks!

Hello @ngupta23 fixed the code quality issues. Thank you

@ngupta23 ngupta23 self-requested a review July 27, 2023 13:31
@ngupta23 ngupta23 merged commit 9080269 into pycaret:master Jul 27, 2023
@ngupta23
Copy link
Collaborator

@beingmechon Thanks for your first contribution. The PR has been merged.

@beingmechon
Copy link
Contributor Author

@beingmechon Thanks for your first contribution. The PR has been merged.

Thank you @ngupta23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants