Skip to content

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Jun 5, 2023

Related Issue or bug

Info about Issue or bug

Closes #3572

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@Yard1
Copy link
Member Author

Yard1 commented Jun 5, 2023

cc @sherpan

@sherpan
Copy link
Contributor

sherpan commented Jun 7, 2023

thanks for tackling this @Yard1 , i guess this fix will be featured on the next release? what is pycaret's release cadence?

@Yard1
Copy link
Member Author

Yard1 commented Jun 7, 2023

Yeah, we should make a release in 1-2 weeks!

@Yard1 Yard1 merged commit aae445a into master Jun 7, 2023
@Yard1 Yard1 deleted the missing_logger_kwarg_fix branch June 7, 2023 17:01
@sherpan
Copy link
Contributor

sherpan commented Jun 20, 2023

thanks @Yard1 , is there anyway i can test before the official release and make sure it is working as expected?

@Yard1
Copy link
Member Author

Yard1 commented Jun 20, 2023

@sherpan pip uninstall -y pycaret && pip install git+https://github.com/pycaret/pycaret.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Comet logging broken due to logging update
2 participants