Skip to content

fix feature selection #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2023
Merged

fix feature selection #3562

merged 2 commits into from
May 19, 2023

Conversation

tvdboom
Copy link
Collaborator

@tvdboom tvdboom commented May 18, 2023 •
edited
Loading

Closes #3556

Describe the changes you've made

Fixes a bug where using a custom estimator for feature selection failed

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tvdboom tvdboom requested review from Yard1 and ngupta23 May 18, 2023 18:34
@tvdboom tvdboom mentioned this pull request May 18, 2023
Closed
3 tasks
@tvdboom tvdboom merged commit 196c580 into master May 19, 2023
@tvdboom tvdboom deleted the fix_estimator_fs branch May 19, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@ngupta23 ngupta23 ngupta23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: "feature_selection_estimator" is not working when using estimater(not string)
3 participants
@tvdboom @Yard1 @ngupta23