Remove leaveoneout #3543
Merged
Remove leaveoneout #3543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngupta23
reviewed
May 10, 2023
| @@ -104,6 +104,14 @@ def test_assign_index(index): | |||
| assert pc.dataset.index[0] != 0 | |||
|
|
|||
|
|
|||
| def test_duplicate_columns(): | |||
There was a problem hiding this comment.
Is this test related to the change to the encoder? Do we need to add a test for the encoding issue?
There was a problem hiding this comment.
it's unrelated. just a minor check I added. I don;t think we need a test for the encoding since it's no longer an issue. Only if users would select specifically the LeaveOneOut encoder, which will only happen if they understand the encoder, in which case they should see it doesn;t work as expected
ngupta23
approved these changes
May 10, 2023
Yard1
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3507
Describe the changes you've made
Change the default encoder for high cardinality features from LeaveOneOut to TargetEncoder
Type of change
Please delete options that are not relevant.