Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented May 6, 2023

Related Issue or bug

Closes #3232

Describe the changes you've made

  • Provided option for users to select seasonality type
  • Reverted back default seasonality type to multiplicative (prior status quo)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been added and updated.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label May 6, 2023
@ngupta23 ngupta23 added this to the 3.0.1 milestone May 6, 2023
@ngupta23 ngupta23 requested review from Yard1 and tvdboom May 6, 2023 15:34
@ngupta23 ngupta23 merged commit 5f2bd5d into master May 6, 2023
@ngupta23 ngupta23 deleted the ts_season_type branch May 6, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Improve seasonality type detection in time series
3 participants