Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Apr 21, 2023

Related Issue or bug

Disabling tests that are failing on GitHub CI (but passing locally). Not sure what the issue is yet, but since it is holding up all PRs, we decided to disable these temporarily until a fix can be found.

Failing tests: https://github.com/pycaret/pycaret/actions/runs/4750735691/jobs/8439195906

Describe the changes you've made

Disabled failing tests

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@ngupta23 ngupta23 requested a review from Yard1 April 21, 2023 00:26
@ngupta23 ngupta23 added this to the 3.0.1 milestone Apr 21, 2023
@ngupta23 ngupta23 merged commit f1615f8 into master Apr 21, 2023
@ngupta23 ngupta23 deleted the disable_failing_tests branch April 21, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants