Skip to content

fix np array check when get_feature_names_out is unavailable #3470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2023
Merged

fix np array check when get_feature_names_out is unavailable #3470

merged 1 commit into from
Apr 9, 2023

Conversation

tvdboom
Copy link
Collaborator

@tvdboom tvdboom commented Apr 8, 2023 •
edited
Loading

Closes #3469

Describe the changes you've made

Fixes a bug where non numerical array checks would fail when get_feature_names_out is not available in a transformer.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tvdboom tvdboom requested a review from Yard1 April 8, 2023 20:34
@tvdboom tvdboom merged commit b44ac84 into master Apr 9, 2023
@tvdboom tvdboom deleted the fix_array_check branch April 9, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: CatBoostEncoder ERROR : get_feature_names_out()
2 participants
@tvdboom @Yard1