Skip to content

add duplicate indices check #3430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 27, 2023
Merged

add duplicate indices check #3430

merged 2 commits into from
Mar 27, 2023

Conversation

tvdboom
Copy link
Collaborator

@tvdboom tvdboom commented Mar 24, 2023 •
edited
Loading

Closes #3428

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@tvdboom tvdboom requested a review from ngupta23 March 24, 2023 14:45
@ngupta23
Copy link
Collaborator

@tvdboom Looks like some existing datasets that were passing are now failing.

ngupta23
ngupta23 approved these changes Mar 27, 2023
View reviewed changes
Copy link
Collaborator

@ngupta23 ngupta23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good pending tests passing.

@ngupta23 ngupta23 added this to the pycaret 3.1.0 milestone Mar 27, 2023
@Yard1
Copy link
Member

Yard1 commented Mar 27, 2023

Looks like the plot failure is the same as on master (some library must have updated)

@tvdboom tvdboom merged commit 70c1024 into master Mar 27, 2023
@tvdboom tvdboom deleted the add_index_check branch March 27, 2023 09:54
@ngupta23 ngupta23 modified the milestones: 3.1.0, 3.0.1 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@ngupta23 ngupta23 ngupta23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

[BUG]: Transformed test set shape (samples) is not the same input test_data shape (samples)
3 participants
@tvdboom @ngupta23 @Yard1