Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Jun 19, 2021

  1. After adding get_fold_generator functionality for time series, compare_models is breaking (not returning any models). This was not caught in CI since the test for compare_models was missing.
  2. Also fixed functional API for blend_models which was failing earlier due to incorrect default metric.

Describe the changes you've made

Fixed the issue mentioned above and added unit test for compare_models.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit test has been added

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 self-assigned this Jun 19, 2021
@ngupta23 ngupta23 added this to the Time Series Alpha Release milestone Jun 19, 2021
@ngupta23 ngupta23 merged commit e68133c into time_series Jun 19, 2021
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants