Skip to content

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

During create_model calls, only folds were displayed earlier (similar to regression/classification). But in time series, since the temporal dependency is maintained in the folds, it is useful to also add the cutoff for the training data to know exactly what was used for training each fold (all values on or before the cutoff are used for training). This has now been added.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Existing unit tests pass

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

image

@ngupta23 ngupta23 merged commit 8f46e98 into time_series Jun 18, 2021
@ngupta23 ngupta23 deleted the ts_add_cutoffs branch June 19, 2021 16:20
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants