Skip to content

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

  • Added support for fold parameter in create_model and tune_model. Allows users to set a different fold than the one used in setup.
  • Hid the data parameter in predict_model until we have multivariate time series.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been added and pass locally.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 requested review from Yard1 and TremaMiguel June 13, 2021 11:28
@ngupta23 ngupta23 changed the title Ts alpha ng Suport for custom folds Jun 13, 2021
@ngupta23 ngupta23 changed the title Suport for custom folds Support for custom folds Jun 13, 2021
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yard1 Yard1 merged commit cb219e1 into time_series Jun 14, 2021
@ngupta23 ngupta23 deleted the ts_alpha_ng branch June 15, 2021 09:46
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants