added dummylogger #1341
Merged
added dummylogger #1341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yard1
approved these changes
Jun 8, 2021
|
Hi. Can we separate the system logging parameter from log_experimemt. Lets create a new parameter called system_log (default to True). The use-case for both these loggers are different. |
|
I added the system_log parameter to (I think) all the setup functions and to the docstrings. Is it automatically added to the documentation as well? |
|
Yes, the docs are auto updated. Could we actually make it so that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issuse or bug
Describe the changes you've made
create_logger returns a dummy logger (does nothing when class.info is called) if name=None. This approach leaves the rest of the code untouched.