Skip to content

Added catboost model #1286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2021
Merged

Added catboost model #1286

merged 3 commits into from
May 25, 2021

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

Added catboost model

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests should catch this new model

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

Catboost is too slow and consumes a lot of memory

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 marked this pull request as ready for review May 23, 2021 22:27
@ngupta23 ngupta23 requested review from Yard1 and TremaMiguel May 23, 2021 22:27
TremaMiguel
TremaMiguel reviewed May 24, 2021
View reviewed changes
pycaret/containers/models/time_series.py
return

catboost_version = tuple([int(x) for x in catboost.__version__.split(".")])
if catboost_version < (0, 23, 2):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can read the required catboost version from the requirements-optional.txt file, otherwise it could be hard to remember to update this part of the code when updating the requirements file.

Copy link
Collaborator Author

@ngupta23 ngupta23 May 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the requirements-optional.txt would reside outside the module and wont be accessible from within - correct?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking it like it's being done in here is correct, as the user may choose to install catboost separately.

TremaMiguel
TremaMiguel reviewed May 24, 2021
View reviewed changes
@Yard1
Copy link
Member

Yard1 commented May 24, 2021 •
edited
Loading

Catboost is too slow and consumes a lot of memory

That's mostly due to it fitting 1000 trees by default. We can consider reducing that number.

@TremaMiguel TremaMiguel merged commit 1b51a9e into time_series May 25, 2021
@ngupta23 ngupta23 deleted the ts_review_inputs branch May 26, 2021 09:57
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

+1 more reviewer

@TremaMiguel TremaMiguel TremaMiguel left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
time_series Topics related to the time series
Projects
None yet
Milestone
Time Series Alpha Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ngupta23 @Yard1 @TremaMiguel