Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented May 16, 2021

Incorporated feedback from internal testing

Bug Fixes

  • Now code will error out when kfold is passed to time series experiment. Was not the case earlier

Minor Enhancements

  • Added alias for rolling window (= expanding window)
  • Reordered metrics
  • Removed unnecessary arguments from several functions such as setup, create_model, tune_model
  • Renamed some models
  • Removed turbo option from BATS and TBATS since it is slower

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been updated and are passing

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ngupta23 ngupta23 merged commit ea0b9c0 into time_series May 17, 2021
@ngupta23
Copy link
Collaborator Author

I merged it since the changes are straightforward.

@ngupta23 ngupta23 deleted the ts_moez_feedback branch May 20, 2021 09:27
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants