Seasonality check Flag #1199
Seasonality check Flag #1199
Conversation
| except KeyError: | ||
| raise ValueError( | ||
| f"Unsupported Period frequency: {seasonal_parameter}, valid Period frequencies: {', '.join(SeasonalParameter.__members__.keys())}" | ||
| ) | ||
|
|
||
| self.seasonal_parameter = seasonal_parameter |
There was a problem hiding this comment.
If seasonal parameter is a string, will the previous statement not be overwritten by this?
There was a problem hiding this comment.
yes, I was missing assigning this case when seasonal_parameter is integer.
There was a problem hiding this comment.
Thanks @TremaMiguel , Can you add unit tests to test for these 2 cases (type of the argument)?
There was a problem hiding this comment.
you mean testing the exceptions raised seasonal_parameter parameter must be an int or str and Unsupported Period frequency ?
There was a problem hiding this comment.
Yes, that could be one of them. In addition, I was referring to specifically testing passing of int and str values and checking that the internal values are set correctly.
Describe the changes you've made
Check seasonal period in data through sktime's
autocorrelation_seasonality_testfunction.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
No tests need.
Describe if there is any unusual behaviour of your code(Write
NAif there isn't)A clear and concise description of it.
Checklist: