Skip to content

added more scikit models along with proper grid search (previously placeholder only) #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 25, 2021
Merged

added more scikit models along with proper grid search (previously placeholder only) #1195

merged 12 commits into from
Apr 25, 2021

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Apr 24, 2021 •
edited
Loading

Describe the changes you've made

  • Scikit models are pipelined (e.g. deseasonalized and detrended). Added grid search for the underlying regressor now (missing previously)
  • Added more models
    • Extra trees
    • XGBoost
    • Light GBM
    • Gradient Boosted Regressor
  • Made unit tests more modular so they pick up new models automatically

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit Tests were rerun

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 requested review from Yard1 and TremaMiguel April 24, 2021 10:59
@ngupta23 ngupta23 changed the title added grid search for rf_dts added more scikit models along with proper grid search (previously placeholder only) Apr 25, 2021
@ngupta23 ngupta23 marked this pull request as ready for review April 25, 2021 14:34
@ngupta23 ngupta23 requested review from TremaMiguel and Yard1 April 25, 2021 14:34
Yard1
Yard1 approved these changes Apr 25, 2021
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - what's the issue with distributions sampling outside the range?

@ngupta23
Copy link
Collaborator Author

LGTM - what's the issue with distributions sampling outside the range?

I am not completely sure why this is happening. If I give a uniform distribution between 0 and 1, in come cases, it is taking a value more than 1 and hence the fit fails. So I just commented it out for now. I will debug later.

TremaMiguel
TremaMiguel reviewed Apr 25, 2021
View reviewed changes
pycaret/tests/test_time_series.py
ts_models = get_all_model_containers(globals_dict)
ts_experiment = load_setup
ts_estimators = []
_model_names = return_model_names()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, that's what I meant to pass through calling a function. Looks good !

@TremaMiguel TremaMiguel merged commit b740156 into time_series Apr 25, 2021
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

+1 more reviewer

@TremaMiguel TremaMiguel TremaMiguel approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
time_series Topics related to the time series
Projects
None yet
Milestone
Time Series Alpha Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ngupta23 @Yard1 @TremaMiguel