Skip to content

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

  • Cleanup of time series metrics
  • Added more metrics for time series
  • Added/Updated function doc strings
  • Type checking cleanup

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Yes, Unit tests have been updated

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 requested review from TremaMiguel and Yard1 March 21, 2021 12:36
@ngupta23 ngupta23 merged commit 93c54d8 into time_series Mar 22, 2021
@ngupta23 ngupta23 deleted the ts_metrics_cleanup branch March 22, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants