Skip to content

Conversation

ngupta23
Copy link
Collaborator

Related Issus or bug

Describe the changes you've made

  • Added more model types for time series
    • Naive Forecaster
    • Polynomial Trend Forecaster
    • Exponential Smoothing
    • Theta Forecaster
  • Unit Tests
    • Updated unit tests for time series splitters
    • Added unit tests for create_models

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests added

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

NA

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@TremaMiguel TremaMiguel merged commit 84ca315 into time_series Mar 2, 2021
@TremaMiguel
Copy link
Contributor

@ngupta23 feel free to delete the branch.

@ngupta23 ngupta23 deleted the ts_more_models branch March 2, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants