Skip to content

Conversation

TremaMiguel
Copy link
Contributor

Related Issuse or bug

[#1078 ]

Describe the changes you've made

Major changes include:

  • Include sktime splitters ExpandingWindowSplitter and SlidingWindowSplitter. link
  • User can define fh (forecast horizon) and cv strategy through fold_strategy parameter. Available options for the user are:
    • 'expandingwindow'
    • 'slidingwindow'
    • 'timeseries'
    • a custom CV generator object compatible with scikit-learn.

Minor changes include:

  • Validate that generated folds do not exceed data points. #L1188, #L1917

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

File test_time_series_splitters.py tests the following:

  • Splitters are correctly initialized given the parameters that the user pass through the setup() function. link
  • ValueError raises if there are not enought data points to generate folds. link

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@TremaMiguel
Copy link
Contributor Author

@ngupta23 is there something we're missing checking on this PR to approve merge ?

@Yard1 Yard1 merged commit 0edbcb6 into time_series Feb 25, 2021
@TremaMiguel TremaMiguel deleted the time_series_splitter branch February 26, 2021 01:45
@ngupta23
Copy link
Collaborator

@TremaMiguel, Looks like @Yard1 merged it so I will review today and get back.

@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants