Skip to content

Conversation

TremaMiguel
Copy link
Contributor

Related Issue or bug

Describe the changes you've made

Major changes of this branch include:

  • Add SMAPE, MAPE, MASE, MAE and RMSE containers for time series. link

Minor changes include:

  • Add sktime as a requirement to requirements-optional to ensure installation during CI stage. link

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Testing changes include:

  • Added time series metrics testing to check_metric function. link
  • Test float values through numpy.testing.assert_almost_equal. example

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@TremaMiguel TremaMiguel requested a review from Yard1 February 13, 2021 18:07
@Yard1 Yard1 merged commit 4a30c39 into time_series Feb 14, 2021
@Yard1
Copy link
Member

Yard1 commented Feb 14, 2021

Thanks a lot, feel free to delete the branch.

@TremaMiguel TremaMiguel deleted the time_series_metrics branch February 14, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants