Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Oct 28, 2021

Fixes:

Describe the changes you've made

  • White Noise test was failing for short time series. Added checks now to take care of this
  • Refactored setup display
  • Refactored check_stats module
  • Also restructured unit tests for check_stats (making them parameterized and breaking into smaller/more modular tests)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been added to test for short time series

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 requested a review from Yard1 October 28, 2021 10:48
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@ngupta23 ngupta23 merged commit 5023c18 into time_series Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants