Skip to content

Conversation

ngupta23
Copy link
Collaborator

Fixes:

Describe the changes you've made

  • Residual plot was performing inplace resetting of fh. This has been fixed now.
  • Also, non availability of residuals in an estimator is caught and an appropriate error is displayed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests to be run on GitHub

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label Oct 21, 2021
@ngupta23 ngupta23 added this to the Time Series Beta Release milestone Oct 21, 2021
@ngupta23 ngupta23 requested review from Yard1 and moezali1 October 21, 2021 23:51
@ngupta23 ngupta23 changed the title Ts beta fixes TS beta fixes Oct 21, 2021
@ngupta23 ngupta23 merged commit 19d476e into time_series Oct 22, 2021
@ngupta23 ngupta23 deleted the ts_beta_fixes branch October 22, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plot_model(model, plot = 'forecast') showing unexpected behavior sometimes
2 participants