Time Series Bug Fixes and Error Handling #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yard1
approved these changes
Oct 10, 2021
| forecaster.fit(y_train, X_train, **fit_params) | ||
| except ValueError as error: | ||
| ## Currently only catching ValueError. Can catch more later if needed. | ||
| logging.error(error) |
There was a problem hiding this comment.
Perhaps we could switch the order around. That's how we do it in other places (first the message, then the exception)
There was a problem hiding this comment.
Thank you. I have update it.
| data.name = "Time Series" | ||
| ## Make a local copy so as not to perfrom inplace operation on the | ||
| ## original dataset | ||
| data_ = data.copy(deep=True) |
There was a problem hiding this comment.
copy() without deep should suffice (unless it's there for a specific reason)
There was a problem hiding this comment.
Just a catch all. Should be the same as without deep since we are passing just a dataframe. Do you see any potential issues with including it?
There was a problem hiding this comment.
Updated anyway now...
This was
linked to
issues
Oct 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issuse or bug
#1665
#1666
Fixes: #[issue number that will be closed through this PR]
Closes #1665
Closes #1666
Describe the changes you've made
Type of change
How Has This Been Tested?
Unit tests pass
Checklist: