Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Oct 9, 2021

Related Issuse or bug

#1663

Describe the changes you've made

Allows passing fh in plot_model

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests have been added

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label Oct 9, 2021
@ngupta23 ngupta23 added this to the Time Series Beta Release milestone Oct 9, 2021
Comment on lines +2456 to +2459
if data_kwargs is None:
data_kwargs = {}
if fig_kwargs is None:
fig_kwargs = {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@ngupta23 ngupta23 merged commit b0be8e6 into time_series Oct 9, 2021
@ngupta23 ngupta23 deleted the ts_plot_predict_fh branch October 9, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time Series plot_model (forecasts) should have an option to take fh value
2 participants