Skip to content

Multiple Fixes and Residual Analysis Added #1620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 3, 2021
Merged

Multiple Fixes and Residual Analysis Added #1620

merged 11 commits into from
Oct 3, 2021

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Sep 27, 2021 •
edited
Loading

Related Issuse or bug

Fixes: #[issue number that will be closed through this PR]

Describe the changes you've made

  • [Enhancement] Adds residual analysis
  • [Bug Fix] Metrics are not displayed when model is loaded back after saving.
  • [Bug Fix] Defaults for functional API plot model were fixed.
  • [Bug Fix]Blending method passed from functional API to OOP call internally now (missing earlier so defaulted to mean all the time)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added the time_series Topics related to the time series label Sep 27, 2021
@ngupta23 ngupta23 added this to the Time Series Beta Release milestone Sep 27, 2021
@ngupta23 ngupta23 changed the title Load test metric Multiple Fixes and Residual Analysis Added Oct 3, 2021
Yard1
Yard1 approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pycaret/internal/pycaret_experiment/time_series_experiment.py Outdated
Comment on lines 2756 to 2758
try:
self.X_test
except AttributeError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, though in other places we use hasattr instead.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in all places except the one noted in the comments.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this exception handling should be inside self._get_model_name(estimator) itself. Not sure why time_series module has to do this. What do you think?

Never mind. I have changed it for now so we can close this out....

ngupta23 and others added 2 commits October 3, 2021 12:42
@Yard1
Copy link
Member

Yard1 commented Oct 3, 2021

@ngupta23 if you are going to go with hasattr, there are several other spots in the PR that are using try except as well

@ngupta23
Copy link
Collaborator Author

ngupta23 commented Oct 3, 2021

@ngupta23 if you are going to go with hasattr, there are several other spots in the PR that are using try except as well

Yes, I changed it in all spots now except

            try:
                model_name = self._get_model_name(estimator)
            except AttributeError:
                # If the model is saved and loaded afterwards,
                # it will not have self._get_model_name
                model_name = estimator.__class__.__name__

I think this exception handling should be inside self._get_model_name(estimator) itself. Not sure why time_series module has to do this. What do you think?

@Yard1
Copy link
Member

Yard1 commented Oct 3, 2021

@ngupta23 That's a good idea, feel free to put it there!

@ngupta23
Copy link
Collaborator Author

ngupta23 commented Oct 3, 2021

@ngupta23 That's a good idea, feel free to put it there!

I don't think I can. Its a method call, so the calling method will have to check for it - correct? Anyway, I have fixed it in my method now.

@ngupta23 ngupta23 merged commit 970eea3 into time_series Oct 3, 2021
@ngupta23 ngupta23 deleted the load_test_metric branch October 3, 2021 22:43
@Yard1
Copy link
Member

Yard1 commented Oct 3, 2021

@ngupta23 Right, I'll take a look at that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@moezali1 moezali1 Awaiting requested review from moezali1

@satya-pattnaik satya-pattnaik Awaiting requested review from satya-pattnaik

Assignees

@Yard1 Yard1

Labels
time_series Topics related to the time series
Projects
None yet
Milestone
Time Series Beta Release
Development

Successfully merging this pull request may close these issues.
2 participants
@ngupta23 @Yard1