Skip to content

Conversation

ngupta23
Copy link
Collaborator

Related Issuse or bug

#1566
#1564
#1563
#1562
#1560
#1559
#1557
#1555

Fixes: #[issue number that will be closed through this PR]

#1566
#1564
#1563
#1562
#1560
#1559
#1557
#1555

Describe the changes you've made

Enhancements and fixes made as per issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tests updated as necessary and rerun locally

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

N/A

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Comment on lines +34 to +44
elif plot == "train_test_split":
plot_data = plot_splits_tt(
train=train, test=test, return_data=return_data, show=show
)
elif plot == "splits_cv":
plot_data = plot_splits_cv(data=data, cv=cv, return_data=return_data, show=show)
elif plot == "cv":
plot_data = plot_cv(data=data, cv=cv, return_data=return_data, show=show)
elif plot == "acf":
plot_data = plot_acf(data=data, return_data=return_data, show=show)
elif plot == "pacf":
plot_data = plot_pacf(data=data, return_data=return_data, show=show)
elif plot == "predictions":
elif plot == "forecast":
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this somewhere in the documentation? If so, has it been updated?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moezali1 will update the documentation before the next release.

@ngupta23 ngupta23 merged commit 0d5ec00 into time_series Sep 19, 2021
@ngupta23 ngupta23 self-assigned this Sep 19, 2021
@ngupta23 ngupta23 added this to the Time Series Beta Release milestone Sep 19, 2021
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants