Skip to content

plot_model functionality #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 4, 2021
Merged

plot_model functionality #1513

merged 6 commits into from
Sep 4, 2021

Conversation

ngupta23
Copy link
Collaborator

Describe the changes you've made

  • Added plot_model functionality for time series

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added unit tests for plot_model functionality

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@ngupta23 ngupta23 added this to the Time Series Beta Release milestone Aug 14, 2021
@ngupta23 ngupta23 marked this pull request as ready for review September 1, 2021 03:54
@ngupta23 ngupta23 changed the title starting point for plot_model functionality plot_model functionality Sep 1, 2021
Yard1
Yard1 approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

pycaret/internal/plots/time_series.py
SlidingWindowSplitter,
)

__author__ = ["satya-pattnaik", "ngupta23"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yard1 Thanks for the CI fixes!

@ngupta23 ngupta23 merged commit e08165b into time_series Sep 4, 2021
@ngupta23 ngupta23 deleted the ts_plot_model branch September 5, 2021 08:57
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yard1 Yard1 Yard1 approved these changes

@TremaMiguel TremaMiguel Awaiting requested review from TremaMiguel

@satya-pattnaik satya-pattnaik Awaiting requested review from satya-pattnaik

@moezali1 moezali1 Awaiting requested review from moezali1

Assignees
No one assigned
Labels
time_series Topics related to the time series
Projects
None yet
Milestone
Time Series Beta Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ngupta23 @Yard1 @satya-pattnaik