Skip to content

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Aug 14, 2021

Related Issuse or bug

  • Info about Issue or bug

Fixes: #[issue number that will be closed through this PR]

Describe the changes you've made

Instead of carrying over fit attributes of the final estimator in a pipeline, we simply use __getattr__ to redirect the calls there, greatly simplifying and futureproofing the code.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

A clear and concise description of it.

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots

Original Updated
original screenshot updated screenshot

@tvdboom tvdboom merged commit a0393a1 into preprocess-revamping Aug 24, 2021
@ngupta23 ngupta23 deleted the update_pipeline branch April 30, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants