Skip to content

Conversation

ngupta23
Copy link
Collaborator

@ngupta23 ngupta23 commented Aug 7, 2021

Related Issuse or bug

  • Upgraded sktime from 0.5.2 to 0.7

Describe the changes you've made

Upgrade sktime

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit Tests pass except preprocessing (since sktime required sklearn 0.24). This preprocessing step has been disabled for now until preprocessing is upgraded.

Describe if there is any unusual behaviour of your code(Write NA if there isn't)

No

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Copy link
Member

@Yard1 Yard1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ngupta23 ngupta23 merged commit 68820a8 into time_series Aug 8, 2021
@ngupta23 ngupta23 deleted the ts_sktime_0p7 branch August 14, 2021 13:43
@ngupta23 ngupta23 added time_series Topics related to the time series and removed time_series_dev labels Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time_series Topics related to the time series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants