fix: blending compatible with sktime 0.7.0 #1469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yard1
reviewed
Jul 24, 2021
pycaret/internal/ensemble.py
Outdated
Comment on lines
123
to
129
| @property | ||
| def _set_weights_none(self): | ||
| self.weights = None | ||
|
|
||
| @property | ||
| def _set_weights_uniform(self): | ||
| self.weights = np.ones(len(self.forecasters)) |
There was a problem hiding this comment.
Shouldn't those be methods? Is this how sktime does it?
There was a problem hiding this comment.
Sktime original implementation doesn't handle voting method, here I should be changing these to appropiate setter for @property
@property
def weights(self):
return self.weights
@weights.setter
def weights(self, value):
self.weights = valueand then call
elif self.method in self._not_required_weights and self.weights:
warnings.warn(
"Unused 'weights' argument. When method='mean' or method='median', 'weights' argument is not provided. Setting weights to `None`"
)
self.weights = NoneThere was a problem hiding this comment.
@Yard1 I think we should open a PR to include voting in sktime original implementation, what are your thoughts on this ?
ngupta23
approved these changes
Jul 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you've made
Reimplement EnsembleForecaster with sktime>=0.7.0
Type of change
Please delete options that are not relevant.
Checklist: