feat: update location display names #1258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwang44
reviewed
Aug 17, 2025
|
Hmmm, not yet. But do we need to run it for the schedule rooms? |
|
i believe we need to run these commands and commit the changes whenever the PR has updated the model (field choices in this case) or the translation strings ( |
|
Got it, I’ll upload migration file later |
db4a108 to
026bc40
Compare
- Rename R012 location constant to R0_ALL for clarity - Add "All rooms" and "R0 (Simulcast)" location options - Update all event model location choices - Generate migrations for events and proposals apps - Update translation files with new location labels This change improves the clarity of room naming conventions and enables better simulcast management.
026bc40 to
971ee13
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1258 +/- ##
=======================================
Coverage 74.59% 74.59%
=======================================
Files 84 84
Lines 3184 3184
=======================================
Hits 2375 2375
Misses 809 809 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mattwang44
reviewed
Aug 19, 2025
- Fill empty msgstr entries in en_US locale with original English text - Add Traditional Chinese translations for zh_Hant locale - Update translations for room locations and UI labels This ensures all translation strings have proper values instead of empty strings.
mattwang44
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description